two bugs fixed in the debian package but not in 1.42

Found a bug? Please report it, but remember to follow the bug reporting guidelines.
Missing a sane feature? Let us know!
But please do NOT request ports to other systems.

Moderator: ZSNES Mods

Post Reply
bztunk
Hazed
Posts: 84
Joined: Mon Dec 27, 2004 9:08 pm
Location: In A.D. 2101, war was beginning.

two bugs fixed in the debian package but not in 1.42

Post by bztunk »

For the first one, see http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=199461 . (fixed since the 1.360 debian package)

Then there's another patch being applied:

Code: Select all

--- zsnes-1.400.orig/src/video/2xsaiw.inc
+++ zsnes-1.400/src/video/2xsaiw.inc
@@ -1288,7 +1288,7 @@
         jz Bits565
 end2:
         mov eax, 1
-        jmp end
+        jmp end1
 Bits555:
          mov edx, 0x7BDE7BDE
          mov eax, colorMask
@@ -1307,7 +1307,7 @@
          mov [eax], edx
          mov [eax+4], edx
          mov eax, 0
-         jmp end
+         jmp end1
 Bits565:
          mov edx, 0xF7DEF7DE
          mov eax, colorMask
@@ -1326,8 +1326,8 @@
          mov [eax], edx
          mov [eax+4], edx
          mov eax, 0
-         jmp end
-end:   
+         jmp end1
+end1:  
          pop edx
         mov esp, ebp
         pop ebp
Seems like it's just renaming the end label to end1. Why, I don't know.

It may be nice to check out http://bugs.debian.org/cgi-bin/pkgreport.cgi?src=zsnes . These bugs doesn't look like they are important, but what do I know.
grinvader
ZSNES Shake Shake Prinny
Posts: 5632
Joined: Wed Jul 28, 2004 4:15 pm
Location: PAL50, dood !

Post by grinvader »

DAMMIT. Wouldn't it be nice for THEM to come here and tell us they do stuff like this, don't you think ?

This behaviour pisses me so much.
I think I'm gonna add a special easter egg for debian only that makes zsnes explode all the ROMdir contents while saying "I'll give you a reason to feel special now BITCH".
皆黙って俺について来い!!

Code: Select all

<jmr> bsnes has the most accurate wiki page but it takes forever to load (or something)
Pantheon: Gideon Zhi | CaitSith2 | Nach | kode54
Nach
ZSNES Developer
ZSNES Developer
Posts: 3904
Joined: Tue Jul 27, 2004 10:54 pm
Location: Solar powered park bench
Contact:

Post by Nach »

Thanks for the info. No idea what the point in the second one is though.

If anyone knows the Debian maintainer do me a favor and beat him up for us for not sending patches back. We shouldn't have to go through every distro's patch list. It's only proper if you fix our code to let us know.
May 9 2007 - NSRT 3.4, now with lots of hashing and even more accurate information! Go download it.
_____________
Insane Coding
grinvader
ZSNES Shake Shake Prinny
Posts: 5632
Joined: Wed Jul 28, 2004 4:15 pm
Location: PAL50, dood !

Post by grinvader »

To look on the bright side, we're now using the Debian's way to handle bug reports / feature requests.

I.e.: "We believe that the <bug you reported / feature you requested> is <fixed / done> in the latest version, which is due to be coded in the next years."

THUMBS UP DEBIAN
Last edited by grinvader on Sat Apr 30, 2005 6:27 pm, edited 1 time in total.
皆黙って俺について来い!!

Code: Select all

<jmr> bsnes has the most accurate wiki page but it takes forever to load (or something)
Pantheon: Gideon Zhi | CaitSith2 | Nach | kode54
bztunk
Hazed
Posts: 84
Joined: Mon Dec 27, 2004 9:08 pm
Location: In A.D. 2101, war was beginning.

Post by bztunk »

Well, it's normal for users to report the bug to debian, since it could be a distribution issue and it would have no place here.

But yeah, usually, when the bug isn't distribution specific the maintainer do report upstream. Why wasn't it done this time, I don't know. The zsnes maintainer looks like he's really slow.

edit: about the second bug, the 1.337-4 changelog write "* Fix build with new NASM"

I guess some version of nasm failed with an end label? I did compile 1.42 with the latest nasm in testing without fixing that though and it worked.
Last edited by bztunk on Sat Apr 30, 2005 6:32 pm, edited 1 time in total.
Nach
ZSNES Developer
ZSNES Developer
Posts: 3904
Joined: Tue Jul 27, 2004 10:54 pm
Location: Solar powered park bench
Contact:

Post by Nach »

Looks very unprofessional to me.

For every single bug reported, I see he writes:

"We believe that the bug you reported is fixed in the latest version of zsnes, which is due to be installed in the Debian FTP archive"
May 9 2007 - NSRT 3.4, now with lots of hashing and even more accurate information! Go download it.
_____________
Insane Coding
bztunk
Hazed
Posts: 84
Joined: Mon Dec 27, 2004 9:08 pm
Location: In A.D. 2101, war was beginning.

Post by bztunk »

Hum... that's an automatic email, written when some script sees in a changelog a "closes: #xxxx" line. And when it says "we believe", it's more like "it's been fixed according to the changelog", it's not some wild guess.
Nach
ZSNES Developer
ZSNES Developer
Posts: 3904
Joined: Tue Jul 27, 2004 10:54 pm
Location: Solar powered park bench
Contact:

Post by Nach »

Based on the problems, it definitly is some wild guess.
May 9 2007 - NSRT 3.4, now with lots of hashing and even more accurate information! Go download it.
_____________
Insane Coding
grinvader
ZSNES Shake Shake Prinny
Posts: 5632
Joined: Wed Jul 28, 2004 4:15 pm
Location: PAL50, dood !

Post by grinvader »

Now, since a bot is impervious to the worst forms of net-torture (including granny pron and gay bukkake), what's the best way to retaliate ?
皆黙って俺について来い!!

Code: Select all

<jmr> bsnes has the most accurate wiki page but it takes forever to load (or something)
Pantheon: Gideon Zhi | CaitSith2 | Nach | kode54
bztunk
Hazed
Posts: 84
Joined: Mon Dec 27, 2004 9:08 pm
Location: In A.D. 2101, war was beginning.

Post by bztunk »

Nach wrote:Based on the problems, it definitly is some wild guess.
The resolutions? Maybe they are. But don't blame it on the script, he's just doing its job :)
Nach
ZSNES Developer
ZSNES Developer
Posts: 3904
Joined: Tue Jul 27, 2004 10:54 pm
Location: Solar powered park bench
Contact:

Post by Nach »

I blame Debian as a whole. If you don't pass changes you made to main code back or see to it that your maintainers do, there's something wrong.

It's nice and all that Debian keeps their Distro rock solid, but there's other people out there too, and they would be nowhere if they didn't have 3rd parties writing software.
May 9 2007 - NSRT 3.4, now with lots of hashing and even more accurate information! Go download it.
_____________
Insane Coding
grinvader
ZSNES Shake Shake Prinny
Posts: 5632
Joined: Wed Jul 28, 2004 4:15 pm
Location: PAL50, dood !

Post by grinvader »

bztunk wrote:
Nach wrote:Based on the problems, it definitly is some wild guess.
The resolutions? Maybe they are. But don't blame it on the script, he's just doing its job :)
We're not blaming the script itself (well, I do, because the message is plain stupid), but the fact that a distro maintainer uses an automated script to reply to bug reports / feature requests regardless of development, without forwarding said reports/requests.
Add to that the automated message lulls users in a false sense of safety - it's already fixed (even if it's not) - and you have a major blunder here.
皆黙って俺について来い!!

Code: Select all

<jmr> bsnes has the most accurate wiki page but it takes forever to load (or something)
Pantheon: Gideon Zhi | CaitSith2 | Nach | kode54
bztunk
Hazed
Posts: 84
Joined: Mon Dec 27, 2004 9:08 pm
Location: In A.D. 2101, war was beginning.

Post by bztunk »

grinvader wrote:Add to that the automated message lulls users in a false sense of safety - it's already fixed (even if it's not) - and you have a major blunder here.
Well, when you see the message appearing, it *is* fixed, if you get the latest debian package.
Joe Camacho
Devil's Advocate
Posts: 2293
Joined: Mon Aug 02, 2004 7:51 pm
Location: Hmo. Son.

Post by Joe Camacho »

grinvader wrote:Now, since a bot is impervious to the worst forms of net-torture (including granny pron and gay bukkake), what's the best way to retaliate ?
Off Topic: Maybe if you send enough mails containing granny porn and gay bukkake it will make the server burst into flames.
*Sometimes I edit my posts just to correct mistakes.
grinvader
ZSNES Shake Shake Prinny
Posts: 5632
Joined: Wed Jul 28, 2004 4:15 pm
Location: PAL50, dood !

Post by grinvader »

bztunk wrote:Well, when you see the message appearing, it *is* fixed, if you get the latest debian package.
Maybe so, but the message is a blatant lie. It is NOT fixed in the latest ZSNES version.
皆黙って俺について来い!!

Code: Select all

<jmr> bsnes has the most accurate wiki page but it takes forever to load (or something)
Pantheon: Gideon Zhi | CaitSith2 | Nach | kode54
bztunk
Hazed
Posts: 84
Joined: Mon Dec 27, 2004 9:08 pm
Location: In A.D. 2101, war was beginning.

Post by bztunk »

grinvader wrote:Maybe so, but the message is a blatant lie. It is NOT fixed in the latest ZSNES version.
It is... in the debian archive.

If you look at the way the confirmation email is send, you can't really send it only when it's fixed in the "real" zsnes, since it's done by reading the debian changelog.
Post Reply