SNES NTSC Composite Video Filter

byuu · Post by **byuu** » Sun May 28, 2006 3:47 am

It would be cooler if it supported automatic aspect correction, too. Modes like 1280x1024 throw an extra level of difficulty into the mix. Here you have a 4:3 monitor, with a 5:4 video mode trying to display an 8:7 video game in the proper aspect ratio.

So far, I just pretend all modes are 4:3. But I think what really needs to be done is to specify what the per-pixel dimensions are, eg height_size / width_size * height = width (5/4*1024=1280), and use that number to convert the pixel size to 8:7, and then multiply that by height to get your final width. And -then- add an option to recursively go through all possible x224 height combinations to find the best fit for the current mode. Fun, hm?

Dmog · Post by **Dmog** » Mon May 29, 2006 7:54 am

byuu wrote:1200x892 is a tiny bit off, but close enough. Unfortunately, none of my five systems support that resolution

Sorry if this is a stupid suggestion, but have you tried creating a custom resolution with powerstrip? I've had no trouble creating a 1200x892 @ 60hz mode on my machine (again, sorry if I'm being completely off-track here)

Firon · Post by **Firon** » Wed Jun 07, 2006 3:48 am

I tried adding various custom resolutions (even interlaced!) with the NVIDIA drivers, but ZSNES just shows a black screen when it tries to use them. I can change on the desktop just fine and they show up without issue, though.

ICEknight · Post by **ICEknight** » Sun Jun 25, 2006 11:30 pm

kick wrote:
The 600x448 size is hardcoded into the filter. Let people bitch about letterboxing. Those of us with eyes will appreciate the proper aspect ratio and non-blurry scanlines.
I appreciate proper aspect ratio,and I don't mind letterboxing.Actually,I love to see the black bars in PAL mode.

If I remember correctly, they weren't black in real hardware.

Perhaps there's something that can be done here to make it more accurate, like filling the unused screen border with the proper color?

blackmyst · Post by **blackmyst** » Mon Jun 26, 2006 1:16 am

ICEknight wrote:
kick wrote:
The 600x448 size is hardcoded into the filter. Let people bitch about letterboxing. Those of us with eyes will appreciate the proper aspect ratio and non-blurry scanlines.
I appreciate proper aspect ratio,and I don't mind letterboxing.Actually,I love to see the black bars in PAL mode.
If I remember correctly, they weren't black in real hardware.

Perhaps there's something that can be done here to make it more accurate, like filling the unused screen border with the proper color?

They look pretty black to me.

ICEknight · Post by **ICEknight** » Mon Jun 26, 2006 7:23 pm

Oops, I think I got it mixed with the Genesis.

lain · Post by **lain** » Mon Dec 25, 2006 6:24 pm

Sorry for bumping such an old thread D: but I was just wondering what the [refresh] thing does when enabled.

xamenus · Post by **xamenus** » Mon Dec 25, 2006 6:42 pm

lain wrote:Sorry for bumping such an old thread D: but I was just wondering what the [refresh] thing does when enabled.

You obviously haven't read the documentation that comes with ZSNES.

BRPXQZME · Post by **BRPXQZME** » Mon Dec 25, 2006 9:41 pm

I invoke my level 10 "Sneaky Bastard" skill to take advantage of this bumped topic:

Any chance this filter could be upgraded to the latest, greatest version? I just don't have the kind of chutzpah it'd take to do it myself, but once it's done it will probably work on the Mac port. My futile attempts ended up producing weird, half-filled screens.

Deathlike2 · Post by **Deathlike2** » Mon Dec 25, 2006 10:47 pm

BRPXQZME wrote:I invoke my level 10 "Sneaky Bastard" skill to take advantage of this bumped topic:

Any chance this filter could be upgraded to the latest, greatest version? I just don't have the kind of chutzpah it'd take to do it myself, but once it's done it will probably work on the Mac port. My futile attempts ended up producing weird, half-filled screens.

I'd like to think it would happen at some point. However, just plugging the code in simply won't work.

BRPXQZME · Post by **BRPXQZME** » Tue Dec 26, 2006 11:58 am

...this, I found out rather quickly. Otherwise I would have just said PLUG IT IN IT WORKS AHAHA or something to that effect. While still utilizing my "Sneaky Bastard" technique, of course.

Post by **Nach** » Wed Dec 27, 2006 1:13 pm

BRPXQZME wrote: Any chance this filter could be upgraded to the latest, greatest version? I just don't have the kind of chutzpah it'd take to do it myself, but once it's done it will probably work on the Mac port. My futile attempts ended up producing weird, half-filled screens.

Can you send me a copy of your current work? All I'm getting is crashing on my end. Although I see some obvious points why the new version isn't just drop in and play.

BRPXQZME · Post by **BRPXQZME** » Wed Dec 27, 2006 3:51 pm

All I did was drop in the new code and changed the line in NTSCFilterDraw to say 288 instead of 576 (this yields half a screen instead of 1/4 of a screen; changing it to 144 looks... interesting). Pretty much anything else I tried that seemed like it'd work caused crashage. And me being me, I didn't try anything besides really cheapass fixes. I didn't look into it too hard. (Also, after about 20 minutes of good ol' fiddlin' with it, I got it to the point where I only get crashing. With either enabling interpolation, enabling ntsc, but never both with the same executable. Hrrrrumph. This is why I hate technology. I'm a CS major, so unlike the Luddites I'm not entirely unfounded here.)

In the meantime, I figured out how to fix the crashing problem with the current code. Turns, out setting SDL_HWSURFACE instead of SDL_SWSURFACE (in sw_draw.c) will give the filter addresses it likes to write to (d'oh!). The SDL_DOUBLEBUF is still a bad idea for OS X, though; with it, HQ2X goes all seizure-licious in certain modes.

Post by **Nach** » Wed Dec 27, 2006 4:29 pm

BRPXQZME wrote: In the meantime, I figured out how to fix the crashing problem with the current code. Turns, out setting SDL_HWSURFACE instead of SDL_SWSURFACE (in sw_draw.c) will give the filter addresses it likes to write to (d'oh!). The SDL_DOUBLEBUF is still a bad idea for OS X, though; with it, HQ2X goes all seizure-licious in certain modes.

That doesn't help me, I'm only using Linux.

This line is crashing for me:
SNES_NTSC_LORES_OUT( 0, line_out [0], SNES_NTSC_OUT_DEPTH );
And I've yet to figure out why...
Although I have yet to take out the really really big guns.

Post by **Nach** » Wed Dec 27, 2006 4:54 pm

Yay for progress!

Cookie if you know which game that's from.

Post by **Nach** » Wed Dec 27, 2006 5:17 pm

I am currently banging my head on the wall, however...

Joe Camacho · Post by **Joe Camacho** » Wed Dec 27, 2006 8:21 pm

Nach wrote:Yay for progress!

Cookie if you know which game that's from.

Battletoads & Double Dragon

Deathlike2 · Post by **Deathlike2** » Wed Dec 27, 2006 11:29 pm

Nach wrote:I am currently banging my head on the wall, however...

Super Metroid. Yes, I know the feeling.

Post by **Nach** » Thu Dec 28, 2006 2:40 am

Cookies to byuu and Joe Camacho.

Post by **pagefault** » Fri Dec 29, 2006 12:08 am

This is implemented in windows, linux is pending.

blargg · Post by **blargg** » Sun Dec 31, 2006 4:24 am

Nach or pagefault, I'd like to discuss how to make future upgrades of the NTSC filter smoother. I had put together a wrapper for zsnes a while back but y'all were still busy with other things at the time. I'm not having much luck finding the ZSNES CVS to see how things are currently handled.

Jipcy · Post by **Jipcy** » Sun Dec 31, 2006 7:29 am

http://zsnes.bountysource.com/svn

BRPXQZME · Post by **BRPXQZME** » Mon Jan 01, 2007 9:26 pm

Nach wrote:
BRPXQZME wrote: In the meantime, I figured out how to fix the crashing problem with the current code. Turns, out setting SDL_HWSURFACE instead of SDL_SWSURFACE (in sw_draw.c) will give the filter addresses it likes to write to (d'oh!). The SDL_DOUBLEBUF is still a bad idea for OS X, though; with it, HQ2X goes all seizure-licious in certain modes.
That doesn't help me, I'm only using Linux.

Helps me, it doesn't crash anymore

(I do believe that deathlike has been denied a cookie, more importantly)

Post by **Nach** » Mon Jan 01, 2007 9:49 pm

There was no cookie offered for the Super Metroid pic, that was too obvious.

blargg, you know where to reach us if you want to discuss anything.

Post by **pagefault** » Wed Jan 03, 2007 3:11 am

Hey blargg, I have a question for you...

How are you outputting the graphics in this version, from what I can you are doing it per line? Does that mean I call this 60 times per second and build a buffer? How should I go about implementing this properly. Before it was easy just taking a buffer of the complete frame. I will have to do some rework on our blitters if this is the case.

Thanks.