New Filters

BugMeNot · Post by **BugMeNot** » Mon Nov 26, 2007 7:50 pm

Hi,

I'd spent many time in creating a library with image filters/scalers. I'd like to see you implementing all of them into ZSNES. This could enhance graphics.

The Package is here http://www.synthelicz.de/data/ImageResizer.rar
The File "classImage.pm" contains all Filters in Perl-Code which could be easily translated to C. Contact infos are stored inside the files as source comments.

snkcube · Post by **snkcube** » Tue Nov 27, 2007 3:51 am

Since ZSNES is open source, why don't you give it a try on implementing the filters yourself?

mudlord · Post by **mudlord** » Tue Nov 27, 2007 4:07 am

Since ZSNES is open source, why don't you give it a try on implementing the filters yourself?

Well, the filters need to be ported to C first. Or the original implementations implemented...

Deathlike2 · Post by **Deathlike2** » Tue Nov 27, 2007 4:29 am

I simply find it amusing that someone using a BugMeNot account is trying to pass off as a developer asking others to "add in his filters" but yet not put in the effort to properly convert said filters into C in the first place.

I mean, that's motivation to get it done!

BugMeNot · Post by **BugMeNot** » Tue Nov 27, 2007 7:51 am

Why should I spend time converting them to C, when my code is there to show principles only. The user benefits from this source implemented in ZSNES. These are NOT MY FILTERS (well not all), but these are good ones. The standard C implementations often lack certain features and can't handle multiple BPP-Modes. the code here shows how it is done using abstract interfaces, so everybody can easily learn from it. Because PERL is a very C-like language, you only have to write new implementations for GetPixel and SetPixel functions and change some interface code of "classImage". Should have been done in one or two hours.

franpa · Post by **franpa** » Tue Nov 27, 2007 9:57 am

so then do it yourself... why contribute something that is in a different language then expect the developers to waste there time converting parts of the code? especially for someone that is too lazy to create there own account...

sweener2001 · Post by **sweener2001** » Tue Nov 27, 2007 12:14 pm

nothing wrong with protecting their privacy, cause, you know, those guys at emulation boards are CRAZY

and i agree with implementing it yourself. if it's as easy as you make it sound, then everybody wins. you get your filters in, we get to enjoy your filters....blah blah blah.

i'm pretty sure that if you show some initiative on your part, the other devs will do the same.

clessoulis · Post by **clessoulis** » Tue Nov 27, 2007 5:10 pm

How is this filter any better than ones already implemented. I honestly dont see how any filter could be better than the LQ/HQX filters.

DancemasterGlenn · Post by **DancemasterGlenn** » Tue Nov 27, 2007 7:43 pm

BugMeNot wrote:Why should I spend time converting them to C, when my code is there to show principles only. The user benefits from this source implemented in ZSNES. These are NOT MY FILTERS (well not all), but these are good ones. The standard C implementations often lack certain features and can't handle multiple BPP-Modes. the code here shows how it is done using abstract interfaces, so everybody can easily learn from it. Because PERL is a very C-like language, you only have to write new implementations for GetPixel and SetPixel functions and change some interface code of "classImage". Should have been done in one or two hours.

Sounds like if you had started working on converting these to C right away instead of asking someone else to do it, we'd already be able to enjoy these spectacular new filters of yours. I'm looking forward to seeing them in action, just as soon as you realize that no one is going to convert them but you.

BugMeNot · Post by **BugMeNot** » Tue Nov 27, 2007 9:39 pm

have you ever looked at the zsnes source code ? its to messy to get into it in minutes...so it's much easier for zsnes developers which had already worked with it. i would need much more time to implement it than they did. it's a simple time comparison. so i will explain why this would be good for the end-user. hq2x does a very well job, you're right. but under certain circumstances another filter could do better. you should also not forget that there are heavy differencies between hq2x and hq3x and between the normal, the bold and the msart version of these two base filters. from my pint of view it's always good to let the user decide on his own what he wants to use.
and i personally got the strange side effect that in zsnes 1.51 the hq filters seem to crash in windowed mode under 32bpp, so a clean implementation could do a more stable job. i don't want to sell filters, i worked these libs out for myself, to see how things go on and i thought it would be nice, if i give you the chance to use code. so i'd like to do you a favour with giving you the sources a wrote. if i had enough time and energy to look deeper into messy code, i would myself give it a try and some day when i'm fed up with having no choices, i would propably do it on my own, but this day lies far in the future so i simply wanted to let you try first if you come first. but i don't want to force anybody. i'll constantly develop my sources and let the link i gave always point to the newest version, so somebody of you could feel free to look at my sources and implement it in zsnes or another project. it's up to you folks.

snkcube · Post by **snkcube** » Tue Nov 27, 2007 11:54 pm

I don't get any crashes using the HQ filter in windowed mode 32bpp. And yeah, it's 1.51.

funkyass · Post by **funkyass** » Wed Nov 28, 2007 1:54 am

A clean implementation will not fix your crashing issue, probably because the problem isn't in the filter code to begin with.

Deathlike2 · Post by **Deathlike2** » Wed Nov 28, 2007 2:33 am

The crashing issue is consistant with NVidia cards and NVidia cards only. I suspect it is the drivers, but noone even bothers reading repeats of the same HQx NVidia bug report that have been cropping up as of late. http://board.zsnes.com/phpBB2/viewtopic.php?t=10785

Besides, it is nice when the written texts by the "op" is completely inconsistant.

Kajuru · Post by **Kajuru** » Mon Dec 03, 2007 1:44 am

Since this bugmenot user can't convert these craptacular filters himself, I totally vote for porting Zsnes to Perl instead.

mudlord · Post by **mudlord** » Mon Dec 03, 2007 3:55 am

Since this bugmenot user can't convert these craptacular filters himself, I totally vote for porting Zsnes to Perl instead.

And rewrite the whole emulator in the process? No thanks, I rather have the C or assembly filters...

Kajuru · Post by **Kajuru** » Tue Dec 04, 2007 5:09 am

Somehow I'm too subtle for the above user grasp

Einherjan · Post by **Einherjan** » Tue Dec 04, 2007 7:30 am

I like how this guy just throws it at you without any proper explanation. It's like some guy selling you his dog but forgets/doesn't tell you that it has rabies. I am missing the point here. Where is who, what, where and why aspects of this presentation. Also if this guy was serious about making this an "official" presentation he should have taken minute to register an account.

This is was indeed humorous though and I commend the guy for trying though.

Post by **grinvader** » Tue Dec 04, 2007 6:50 pm

why the hell is this shit still unlocked

oh wai-

ZSNES board

New Filters

New Filters

Re: New Filters